Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7748: fix namings #8780

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Update EIP-7748: fix namings #8780

merged 5 commits into from
Aug 19, 2024

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Aug 2, 2024

This PR fixes:

  • A phase naming which was referring to a phase that doesn't exist (in the final proposed version of the EIP).
  • A rename of the BasicDataPhase, since as mentioned by @gabrocheleau it might create some confusion since the semantics of BasicData are different in VKT.

@jsign
eip-7748: fix phase naming
e08e005 
Signed-off-by: Ignacio Hagopian <[email protected]>
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Aug 2, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 2, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title eip-7748: fix namings Update EIP-7748: fix namings Aug 2, 2024
@jsign jsign mentioned this pull request Aug 2, 2024
Merged
jsign
jsign commented Aug 2, 2024
View reviewed changes
EIPS/eip-7748.md Outdated Show resolved Hide resolved
@jsign
eip-7748: rename phase
76df139 
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
jsign commented Aug 2, 2024
View reviewed changes
EIPS/eip-7748.md
class BasicDataPhase:
class AccountDataPhase:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @gabrocheleau, we decided to rename it AccountDataPhase since BasicDataPhase is a bit off, considering that in VKT, it usually leaves out the code-hash (which, in case of the migration, is also moved).

We'd like at least one extra approval for this renaming (or new suggestion!) from another author.

cc @gballet @g11tech @tanishqjasoria

(Note: avoiding switching from Draft to avoid automerge)

gabrocheleau
gabrocheleau reviewed Aug 2, 2024
View reviewed changes
EIPS/eip-7748.md Outdated Show resolved Hide resolved
@jsign
fix comment
34671a4 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign
fix rationale title
d360876 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign
improve comment
63438ad 
Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
gballet approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@gballet gballet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually wonder if AccountPhase wouldn't be better, since "account data" could be interpreted as "account storage".

@jsign
Copy link
Contributor Author

jsign commented Aug 19, 2024 •
edited
Loading

LGTM. I actually wonder if AccountPhase wouldn't be better, since "account data" could be interpreted as "account storage".

Thing is that AccountPhase mentions Account. In case of smart-contract accounts, Account means "everything" (header + storage).

I agree that AccountData still doesn't feel quite right. We can keep thinking and come up with something better in the future.

@jsign jsign marked this pull request as ready for review August 19, 2024 12:35
@jsign jsign requested a review from eth-bot as a code owner August 19, 2024 12:35
@eth-bot eth-bot enabled auto-merge (squash) August 19, 2024 16:14
eth-bot
eth-bot approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3ba7711 into ethereum:master Aug 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet approved these changes

@tanishqjasoria tanishqjasoria tanishqjasoria approved these changes

@gabrocheleau gabrocheleau gabrocheleau approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsign @eth-bot @gballet @tanishqjasoria @gabrocheleau